[FIX] svg: avoid rjsmin issue caused by nested template literals#8994
Open
rmbh-odoo wants to merge 1 commit into
Open
[FIX] svg: avoid rjsmin issue caused by nested template literals#8994rmbh-odoo wants to merge 1 commit into
rmbh-odoo wants to merge 1 commit into
Conversation
Before this commit: - In Odoo, when `debug=assets` is disabled, bundles are minified using `rjsmin`. - Nested template literals in SVG-related code break CSS output. - This leads to incorrect rendering and some SVGs not showing. After this commit: - Removed nested template literals from SVG code. - Ensures correct CSS generation after minification. - SVGs now render properly in production. Task: 6317134
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description:
Current behavior before PR:
debug=assetsis disabled, bundles are minified usingrjsmin.Desired behavior after PR is merged:
Task: 6317134
review checklist