[FIX] HeaderVisibility: fix getNextVisibleCellPosition getter #9040
Open
rrahir wants to merge 2 commits into
Open
[FIX] HeaderVisibility: fix getNextVisibleCellPosition getter #9040rrahir wants to merge 2 commits into
getNextVisibleCellPosition getter #9040rrahir wants to merge 2 commits into
Conversation
The edition plugin would modify the selection whether or not it had control over it when changing sheet. The idea is to keep the composer over a visible cell but this only make sense if the composer is actually active. In itself, this did not have any impact because the selectionPlugin synchronizes its state with the SelectionStreamProcessor at the end of the dispatch cycle (when it has the control over it). Task: 6340589
The getter claimed to always return a cell position but the typing was ignored voluntarily and in some edge cases, the getter could return an undefined HeaderIndex for the columns or the rows. This could lead to crashes as the result of the getter was fed to the SelectionStreamProcessor, which throws an error when given an invalid position. Task: 6340589
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist