[FIX] calendar chart: skip missing value tooltips#9048
Open
dhrp-odoo wants to merge 1 commit into
Open
Conversation
Calendar chart datasets use `data` as a Chart.js rendering payload, where every bucket is drawn with a constant value. The actual cell values are stored separately in `values`, which is only used by our tooltips and show-values plugin. Before this commit, missing calendar values were stored as `NaN` in `values`. This is the right sentinel for Chart.js data points, but not for this metadata: the tooltip filter only skips `undefined`, so missing buckets still displayed a tooltip and formatted `NaN` as `1.00e-NaN`. This commit stores missing calendar metadata as `undefined`, keeping empty buckets out of tooltips/show-values while preserving real numeric values. Task: 6276800
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description:
Calendar chart datasets use
dataas a Chart.js rendering payload, where every bucket is drawn with a constant value. The actual cell values are stored separately invalues, which is only used by our tooltips and show-values plugin.Before this commit, missing calendar values were stored as
NaNinvalues. This is the right sentinel for Chart.js data points, but not for this metadata: the tooltip filter only skipsundefined, so missing buckets still displayed a tooltip and formattedNaNas1.00e-NaN.This commit stores missing calendar metadata as
undefined, keeping empty buckets out of tooltips/show-values while preserving real numeric values.Task: 6276800
review checklist