[FIX] removing skipping already validation rebuilt#542
Merged
Conversation
mmahrouss
force-pushed
the
alpha-fix-skipping-rebuilding-validation-mdms
branch
from
7cabf7a to
b7e6285
Compare
fda-odoo
requested changes
Mar 18, 2026
| } | ||
| let sym = session.sync_odoo.pop_item(BuildSteps::ARCH); | ||
| if let Some(sym_rc) = sym { | ||
| if DEBUG_THREADS { |
Collaborator
There was a problem hiding this comment.
DEBUG_THREAD is meant to debug communication and message order between threads.
To debug steps, you should rather use DEBUG_STEPS
Collaborator
Author
There was a problem hiding this comment.
Alright, will update it now
This was only rarely occurring, and it was causing an issue because we were re-adding files in add_dependents_to_validation which is valid for when something in base depends on a model. which is not common enough to cause errors, but leaving it like so can leave some base files not built and stuck and pending
mmahrouss
force-pushed
the
alpha-fix-skipping-rebuilding-validation-mdms
branch
from
b7e6285 to
541b71f
Compare
fda-odoo
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was only rarely occurring, and it was causing an issue because we were re-adding files in add_dependents_to_validation which is valid for when something in base depends on a model. which is not common enough to cause errors, but leaving it like so can leave some base files not built and stuck and pending