Fix version detection for branch layout with /#1441
Open
m-chalin wants to merge 2 commits into
Open
Conversation
…ches
Use split('/', 3) consistently when extracting branch names from git refs
so nested paths like 19.0/foo are not truncated to foo.
Match base bundles when branch names use a slash version prefix (e.g. 19.0/foo) in addition to the existing hyphen prefix (e.g. 19.0-dev-tri).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With commit 3ec0f7e runbot supports branches with /.
But the version detection was not working for branches like 19.0/foo.