Skip to content

[IMP] util/fields: dump_field_to_chatter column fallback#455

Closed
aj-fuentes wants to merge 1 commit into
odoo:masterfrom
odoo-dev:master-imp_dump_field_fallback-afu
Closed

[IMP] util/fields: dump_field_to_chatter column fallback#455
aj-fuentes wants to merge 1 commit into
odoo:masterfrom
odoo-dev:master-imp_dump_field_fallback-afu

Conversation

@aj-fuentes

Copy link
Copy Markdown
Contributor

For the cases when mail is not installed.

@robodoo

robodoo commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Pull request status dashboard

@aj-fuentes
aj-fuentes requested a review from KangOl June 23, 2026 10:00
Comment thread src/util/fields.py
Comment thread src/util/fields.py Outdated
ON batch.id = t.id
{fk_join}
{value_join}
GROUP BY t.{res_id}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work with the "explode" done on t.id?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it doesn't. I think we need to fix the batch CTE below. I will check.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a different version. Now with clear different queries. There is a test as well for parallel updates.

@aj-fuentes
aj-fuentes force-pushed the master-imp_dump_field_fallback-afu branch 2 times, most recently from ed55699 to ac3a4c2 Compare June 23, 2026 13:02
Comment thread src/util/fields.py
(``jsonb``) columns are written through their ``en_US``
key.
:param str where: extra SQL ``WHERE`` condition on the source records. It is a
``str.format`` template whose ``{0}`` is the source table alias; use it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a slight change, since this util was introduced very recently breaking scripts should be minimal. I could introduce a static check assert where is None or '{0}' in where to avoid missing it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may work without the table alias if there are no ambiguities.

@aj-fuentes
aj-fuentes force-pushed the master-imp_dump_field_fallback-afu branch from ac3a4c2 to d5de3ee Compare June 26, 2026 08:45
@KangOl

KangOl commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

upgradeci retry with always only crm hr event

For the cases when `mail` is not installed.
@aj-fuentes
aj-fuentes force-pushed the master-imp_dump_field_fallback-afu branch from e2d8e35 to f4ae0e3 Compare July 13, 2026 09:06
@aj-fuentes

Copy link
Copy Markdown
Contributor Author

I've rebased to solve conflicts. This should be good to go.

@KangOl KangOl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo

robodoo commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@aj-fuentes @KangOl linked pull request(s) odoo/upgrade#10571 not ready. Linked PRs are not staged until all of them are ready.

robodoo pushed a commit that referenced this pull request Jul 14, 2026
For the cases when `mail` is not installed.

closes #455

Related: odoo/upgrade#10571
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
robodoo pushed a commit that referenced this pull request Jul 14, 2026
For the cases when `mail` is not installed.

closes #455

Related: odoo/upgrade#10571
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>
@robodoo robodoo closed this in e1456f4 Jul 14, 2026
@robodoo robodoo added the 19.5 label Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants