[IMP] util/modules: add xmlid_mapping param to merge_module#463
Open
apan-odoo wants to merge 1 commit into
Open
[IMP] util/modules: add xmlid_mapping param to merge_module#463apan-odoo wants to merge 1 commit into
xmlid_mapping param to merge_module#463apan-odoo wants to merge 1 commit into
Conversation
Contributor
Contributor
Author
|
Example usage: util.merge_module(
cr,
"l10n_ar_stock_batch",
"l10n_ar_stock",
xmlid_mapping={
"action_generate_delivery_guide": "action_generate_delivery_guide_for_batch",
},
) |
393fb58 to
f755b3a
Compare
Contributor
|
upgradeci retry with always only base |
f755b3a to
af0606e
Compare
Contributor
|
Modifying I would also verify that the mapping doesn't contain fully-qualified xmlids, like for the |
af0606e to
9bef7bc
Compare
Contributor
Author
Considered |
xmlid_mapping param to rename/merge modulexmlid_mapping param to merge_module
KangOl
reviewed
Jul 10, 2026
aj-fuentes
reviewed
Jul 10, 2026
9bef7bc to
7acf5a8
Compare
Contributor
|
Can you please rebase? |
aj-fuentes
reviewed
Jul 10, 2026
Comment on lines
+454
to
+459
| present in `into` (the warning above), even though they | ||
| refer to unrelated records; without this, that XMLID's | ||
| record would simply be deleted rather than merged. Each | ||
| pair is moved via :func:`rename_xmlid` before the general | ||
| data-merge query runs, so it's excluded from the | ||
| collision check and survives the merge under its new name. |
Contributor
There was a problem hiding this comment.
Too verbose. Too many implementation details.
Suggested change
| present in `into` (the warning above), even though they | |
| refer to unrelated records; without this, that XMLID's | |
| record would simply be deleted rather than merged. Each | |
| pair is moved via :func:`rename_xmlid` before the general | |
| data-merge query runs, so it's excluded from the | |
| collision check and survives the merge under its new name. | |
| present in `into`. | |
| See :func:`~odoo.upgrade.util.records.rename_xmlid` |
Cross file func references don't work unless fully qualified
Add an optional `xmlid_mapping` param to rename specific XMLIDs during a module merge, before the rest of the bulk move happens.
7acf5a8 to
5ab8299
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add an optional
xmlid_mappingparam to rename specific XMLIDs during a modulerename/merge, before the rest of the bulk move happens.