Conversation
Owner
oduortoni
commented
Feb 13, 2026
- will make it easier to transition into better logging utilities like log files
- refactor da_append to wrap (array)
- will make it easier to transition into better logging utilities like log files - refactor da_append to wrap (array)
koutoftimer
requested changes
Feb 14, 2026
Owner
Author
|
The 'router_free' is intentionally commented out. It is part of the TODO.
It will make sense once we handle graceful shutdown.
…On Sat, 14 Feb 2026 at 15:42, koutoftimer ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In src/lib/http/http_server.c
<#48 (comment)>
:
> + // info("http/server.c");
+ // info("Router address: %p\n", (void*)router);
+ // info("Dispatcher address: %p\n", (void*)router->dispatcher);
The benefit of using VCS like git is that you don't have to copy or
comment out the code, you can just get rid of it because it will stay in
the history anyway.
------------------------------
In src/main.c
<#48 (comment)>
:
> http.ListenAndServe(hostname, router);
/*
* TODO: This is never reached due to infinite listener that stops on
* CTRL + C
* - Need to add a way to handle graceful shut down
*/
- printf("\n\n\t << Graceful Shutdown >>\n\n");
- router_free(router);
+ // info("\n\n\t << Graceful Shutdown >>\n\n");
+ // router_free(router);
Is router_free mistakenly commented ?
—
Reply to this email directly, view it on GitHub
<#48 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIHMOL5GYK5GXA34RQDDUQT4L4J25AVCNFSM6AAAAACVA3YGAGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQMBRG43TQMZXGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.