Provide userscript metadata that works#2
Open
chocolateboy wants to merge 1 commit intoodyniec:masterfrom
chocolateboy:working-metadata
Open
Provide userscript metadata that works#2chocolateboy wants to merge 1 commit intoodyniec:masterfrom chocolateboy:working-metadata
chocolateboy wants to merge 1 commit intoodyniec:masterfrom
chocolateboy:working-metadata
Conversation
The default userscript metadata doesn't work, and doesn't raise an error. Add a copy 'n' pasteable stanza that works so the library can be used without diving into the source code. * `GM_addStyle` is needed for the default mode (iframe). * `GM_registerMenuCommand` is needed for the suggested `menuCommand: true` option. * GitHub shouldn't be used as a CDN. * GreasyFork requires 3rd party libraries served from GitHub mirror CDNs to have either a commit hash or a tag. In the absence of any MonkeyConfig tags/releases, use the former.
ajorpheus
approved these changes
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default userscript metadata doesn't work, and doesn't raise an error. Add a copy 'n' pasteable stanza that works so the library can be used without diving into the source code.
GM_addStyleis needed for the default mode (iframe).GM_registerMenuCommandis needed for the suggestedmenuCommand: trueoption.