-
Notifications
You must be signed in to change notification settings - Fork 31
Non-incremental attack tables #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-incremental attack tables #12
Conversation
cf3c48e to
7528d9e
Compare
|
re codestyle comments: thanks, but i can read discord. i'm not updating codestyle until consensus has been reached. in any case, brace style was predefined by clang-format, and i will not be manually updating it. also, i'm certainly not going to update codestyle of existing code in this PR. |
|
Terrific work. I've skimmed through the code a couple times. I will try to check it once more in a few hours. In the meantime, i'm gonna ask some other guys to review this. Needless to say, the particular care in reviewing this is due to the huge amount of code we are adding. Also i am gonna wait for the style polls to end and for the whole main branch to be brought to the same codestyle (which i think you are doing also for your pr). Finally, if possible, solve the conflicts in preparation for a future merge. |
281a568 to
e2b7478
Compare
|
rebased, enabled tests on CI, made macos build for x64 rather than arm64 (for now), completely removed use of |
|
We now have clang-tidy, on top of better defined clang-format. You can rebase on main and run it on ur branch. |
TheRealGioviok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just rebase + gitformat and use a clearer function for the bit popping. This is ready to be merged otherwise.
|
Updated. |
With movegen and perft.
Note this is slow because it's non-incremental (doing 16x more vector permutations than required).
Incremental version comes next.
We also have a testing infrastructure that uses ctest.
A simple way to run tests is: