Skip to content

Conversation

@87flowers
Copy link
Contributor

With movegen and perft.
Note this is slow because it's non-incremental (doing 16x more vector permutations than required).

Incremental version comes next.

We also have a testing infrastructure that uses ctest.

A simple way to run tests is:

mkdir build
cd build
cmake ..
make test

@87flowers 87flowers force-pushed the slow-movegen branch 2 times, most recently from cf3c48e to 7528d9e Compare June 1, 2025 22:50
@87flowers
Copy link
Contributor Author

87flowers commented Jun 2, 2025

re codestyle comments: thanks, but i can read discord. i'm not updating codestyle until consensus has been reached. in any case, brace style was predefined by clang-format, and i will not be manually updating it. also, i'm certainly not going to update codestyle of existing code in this PR.

@TheRealGioviok
Copy link
Contributor

Terrific work.

I've skimmed through the code a couple times. I will try to check it once more in a few hours. In the meantime, i'm gonna ask some other guys to review this. Needless to say, the particular care in reviewing this is due to the huge amount of code we are adding. Also i am gonna wait for the style polls to end and for the whole main branch to be brought to the same codestyle (which i think you are doing also for your pr). Finally, if possible, solve the conflicts in preparation for a future merge.

@87flowers 87flowers force-pushed the slow-movegen branch 5 times, most recently from 281a568 to e2b7478 Compare June 2, 2025 12:39
@87flowers
Copy link
Contributor Author

rebased, enabled tests on CI, made macos build for x64 rather than arm64 (for now), completely removed use of union

@TheRealGioviok
Copy link
Contributor

We now have clang-tidy, on top of better defined clang-format. You can rebase on main and run it on ur branch.

Copy link
Contributor

@TheRealGioviok TheRealGioviok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rebase + gitformat and use a clearer function for the bit popping. This is ready to be merged otherwise.

@87flowers
Copy link
Contributor Author

Updated.

@TheRealGioviok TheRealGioviok merged commit 7f9f56f into official-clockwork:main Jun 3, 2025
12 checks passed
@87flowers 87flowers deleted the slow-movegen branch June 3, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants