fix: relax device selection constraints#18
Merged
Merged
Conversation
Some users have the MIDI device's manufacturer reporting as "" and the device name as "omx-27-v3". This change gives us some flexibility on how we match devices, and now only looks for the base device name as a substring and ignores manufacturer
euphemism
force-pushed
the
editor-rewrite
branch
from
89acb98 to
2bf5f83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users have the MIDI device's manufacturer reporting as "" and the device name as "omx-27-v3". This change gives us some flexibility on how we match devices, and now only looks for the base device name as a substring and ignores manufacturer.
Also: Updated the Prettier config to enforce semi-colons, but forgot to commit that separately. Sorry for the noise.