text emitter: suggest adding //@check-pass when no error patterns present
#358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resent The current error message is pretty inactionable -- one needs to dig into the documentation to even learn about `//@check-pass`. This change will hopefully reduce the confusion.
ada4a
force-pushed
the
suggest-check-pass
branch
from
9da0499 to
25af7c7
Compare
oli-obk
approved these changes
Dec 20, 2025
Owner
|
CI failure is some spurious ordering issue that I haven't figured out yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current error message is pretty inactionable -- one needs to dig
into the documentation to even learn about
//@check-pass. This changewill hopefully reduce the confusion.
TODO (check if already done)