Add GitHub actions to test ESP builds as a automated merge check for PRs#155
Open
tmcadam wants to merge 9 commits intoolliw42:mainfrom
Open
Add GitHub actions to test ESP builds as a automated merge check for PRs#155tmcadam wants to merge 9 commits intoolliw42:mainfrom
tmcadam wants to merge 9 commits intoolliw42:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains a simple github action that runs a
pio runon pushes to eithermainor any branch beginning withdev-esp. This will test that all ESP targets compile. This can be configured as a branch protection formainmeaning any PR tomainmust have a successful run of this action, before the merge button is enabled (override is possible by admins).The binaries produced by
pio runare discarded.Based on:
https://docs.platformio.org/en/stable/integration/ci/github-actions.html#using-cmd-run-command
Other automated checks we could consider are:
This has been tested and is ready to merge. Once merged it won't have any impact on current workflows until enabled as a branch protection in the Github GUI.