Update Node Serialport to latest version and remove old Winston dependency#14
Open
chrisl8 wants to merge 4 commits intoomcaree:masterfrom
Open
Update Node Serialport to latest version and remove old Winston dependency#14chrisl8 wants to merge 4 commits intoomcaree:masterfrom
chrisl8 wants to merge 4 commits intoomcaree:masterfrom
Conversation
This was done with minimal changes. Further changes should probably be made to improve code, but this is enough to get it working.
Winston 0.8 causes errors in modern Node.js versions. Updating code to use Winston 3 is non-trivial, and the built in console functions appear to work well enough.
chrisl8
changed the title
…lities. - I ran the tests and tested the code and it appears to still work. - I will continue to use this code on my own system and update this or report if I find any issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done with minimal changes. Further changes should probably be made to improve code, but this is enough to get it working.
Using the latest Serialport package is important to avoid bugs found in older versions.
The installed version of Winston was causing error in the current LTS Node.js version. Updating to Winston 3 is non-trivial, and I could not see any benefit to using Winston over just using console.