ImageReader: do not check file handle for in-memory sources#4414
Closed
sbesson wants to merge 1 commit into
Closed
ImageReader: do not check file handle for in-memory sources#4414sbesson wants to merge 1 commit into
sbesson wants to merge 1 commit into
Conversation
If a file has been mapped into memory via the `Location.mapFile()` API, skip the location checks entirely instead of printing an ERROR level warning
Member
melissalinkert
left a comment
melissalinkert
left a comment
There was a problem hiding this comment.
I think I'm OK with this change, but in the case of non-fake files with non-zero length (as in #4413), I wouldn't have expected new Location(id).length() to return 0.
Looking at the Location constructor:
https://github.com/ome/ome-common-java/blob/master/src/main/java/loci/common/Location.java#L234
and:
https://github.com/ome/ome-common-java/blob/master/src/main/java/loci/common/Location.java#L370
that's accounting for String -> String mapping, but not String -> IRandomAccess. That's almost certainly incorrect, and probably worth fixing as well.
Member
Author
|
Proposing to close this fix in favour of ome/ome-common-java#113 which allows the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4413
If a file has been mapped into memory via the
Location.mapFile()API, skip the location checks entirely instead of printing an ERROR level warning