Skip to content
This repository was archived by the owner on Jun 18, 2021. It is now read-only.

Revert some performance improvement changes to ansible.cfg#125

Merged
joshmoore merged 2 commits intoome:masterfrom
manics-archive:ansible_cfg_revert
Sep 29, 2016
Merged

Revert some performance improvement changes to ansible.cfg#125
joshmoore merged 2 commits intoome:masterfrom
manics-archive:ansible_cfg_revert

Conversation

@manics
Copy link
Copy Markdown
Member

@manics manics commented Sep 27, 2016

They're both useful but profiling adds extra output which obscures the rest of the ansible-playbook output, and pipelining is causing problems at the moment. These should be investigated later.

It's causing too many problems at the moment, we should return to it later.
It's useful but adds unnecessary output which obscure the final status.
Should be enabled manually when required.
@atarkowska
Copy link
Copy Markdown
Member

atarkowska commented Sep 27, 2016

looks good, it works

without this PR:

(reverse-i-search)`dev': ansible-playbook os-devspace.yml -e vm_name=ola-test-devspace -e vm_key_name=ola
(dev_tools) MacBookPro:ansible ola$ ansible-playbook -i ~/OMERO/SYSADMIN/management_tools/ansible/devspace  -u centos devspace.yml

PLAY [devspace] ****************************************************************

TASK [setup] *******************************************************************
Tuesday 27 September 2016  16:18:33 +0100 (0:00:00.051)       0:00:00.051 ***** 
ok: [10.0.51.143]

TASK [upgrade-distpackages : system packages | upgrade] ************************
Tuesday 27 September 2016  16:18:33 +0100 (0:00:00.896)       0:00:00.947 ***** 
failed: [10.0.51.143] (item=[u'*']) => {"failed": true, "item": ["*"], "module_stderr": "sudo: sorry, you must have a tty to run sudo\n", "module_stdout": "", "msg": "MODULE FAILURE", "parsed": false}

NO MORE HOSTS LEFT *************************************************************

PLAY RECAP *********************************************************************
10.0.51.143                : ok=1    changed=0    unreachable=0    failed=1   

Tuesday 27 September 2016  16:18:34 +0100 (0:00:00.254)       0:00:01.202 ***** 
=============================================================================== 
setup ------------------------------------------------------------------- 0.90s
upgrade-distpackages : system packages | upgrade ------------------------ 0.25s

with this PR:

(dev_tools) MacBookPro:ansible ola$ git merge manics/ansible_cfg_revert
Updating e42c17f..65df296
Fast-forward
 ansible/ansible.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(dev_tools) MacBookPro:ansible ola$ ansible-playbook -i ~/OMERO/SYSADMIN/management_tools/ansible/devspace  -u centos devspace.yml

PLAY [devspace] ****************************************************************

TASK [setup] *******************************************************************
ok: [10.0.51.143]

TASK [upgrade-distpackages : system packages | upgrade] ************************
changed: [10.0.51.143] => (item=[u'*'])

TASK [upgrade-distpackages : system | current running kernel] ******************
ok: [10.0.51.143]

...
RUNNING HANDLER [docker : restart docker] **************************************
changed: [10.0.51.143]

PLAY RECAP *********************************************************************
10.0.51.143                : ok=30   changed=25   unreachable=0    failed=0   

@snoopycrimecop
Copy link
Copy Markdown
Member

Conflicting PR. Removed from build MANAGEMENT_TOOLS-merge#972. See the console output for more details.
Possible conflicts:

@joshmoore
Copy link
Copy Markdown
Member

Merging with a few caveats:

  • let's leave sudo: sorry, you must have a tty to run sudo #118 open and try to solve our sudo issues as soon as possible (>Oct)
  • I'll activate profiling locally for me, but I encourage everyone to turn it on since it clearly points to what stages are taking too long while a playbook is under development.

@joshmoore joshmoore merged commit 44fc1dc into ome:master Sep 29, 2016
@manics manics deleted the ansible_cfg_revert branch October 5, 2016 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants