Open
Conversation
Automated Review URLs |
Contributor
Author
|
The failing test is somewhat subjective, about the image label's color JSON array. The spec says "this contains one entry per label", which is probably a MUST. If the label zarr array were zero-size, the color JSON array could strictly be empty and valid, although that's obviously a pathological case. I'm OK with reverting this test to empty color arrays as invalid. |
Contributor
Author
|
If this is acceptable I'll make the same changes to the previous and future versions. |
jo-mueller
requested changes
Apr 9, 2026
jo-mueller
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the test cases listed in ome/ngff#325