Skip to content

Bump ch.qos.logback:logback-classic from 1.3.16 to 1.5.34#115

Merged
melissalinkert merged 3 commits into
ome:masterfrom
sbesson:logback_1.5
Jun 1, 2026
Merged

Bump ch.qos.logback:logback-classic from 1.3.16 to 1.5.34#115
melissalinkert merged 3 commits into
ome:masterfrom
sbesson:logback_1.5

Conversation

@sbesson
Copy link
Copy Markdown
Member

@sbesson sbesson commented Jun 1, 2026

With the increase of the minimal runtime requirement to Java 11, it should be safe to move to the active 1.5.x series of logback - https://logback.qos.ch/news.html

@sbesson sbesson requested a review from melissalinkert June 1, 2026 14:04
@melissalinkert
Copy link
Copy Markdown
Member

1.5.26 appears to be the last version that passes tests. I suspect qos-ch/logback@e7764f4#diff-f9f1d5abe1f308025458aaacb10684682c0521616287e3a923ab14015e513579 is the relevant change.

The issue is that in LogbackTools.isEnabled(), ConfigurationWatchListUtil.getMainWatchURL(loggerContext) returns null; a non-null value is expected when a logback configuration file is present. I don't yet know of an alternative solution.

@melissalinkert
Copy link
Copy Markdown
Member

See also qos-ch/logback#1019. The suggestion to add scan=true to the configuration file may fix the test, but requiring that all external configuration files be updated in order to make LogbackTools.isEnabled() work correctly is probably not what we want.

@sbesson sbesson changed the title Bump ch.qos.logback:logback-core from 1.3.16 to 1.5.34 Bump ch.qos.logback:logback-classic from 1.3.16 to 1.5.34 Jun 1, 2026
@sbesson
Copy link
Copy Markdown
Member Author

sbesson commented Jun 1, 2026

Thanks @melissalinkert, looks like this fixed the issue. We probably need to consider the implications but immediate thought is since logback is an optional dependency, a consumer might choose to use a version lower than 1.5.26 (including the series 1.3.x and 1.4.x).
In the context of Bio-Formats/OMERO, we should be able to track the latest version on the 1.5.x series and update our configuration files accordingly e.g. in the command-line tools.

@melissalinkert
Copy link
Copy Markdown
Member

That's fair. I guess then let's merge and evaluate against the whole stack - we've already discussed a second release that includes #108, so if we need to rethink anything here there is opportunity to do so before 9.0.0.

@melissalinkert melissalinkert merged commit 91f185f into ome:master Jun 1, 2026
16 checks passed
@sbesson sbesson deleted the logback_1.5 branch June 1, 2026 21:38
@sbesson
Copy link
Copy Markdown
Member Author

sbesson commented Jun 2, 2026

This has been released as org.openmicroscopy:ome-common:6.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants