Migrate away from easy_localization (#252)#255
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughRemoves the whole translations subsystem: deletes translation CI workflows and validation, removes translation docs and all locale JSON/PO files (including backups and package.json), removes Qodo config, updates .metadata revision hashes, and adds a new auto-localization GitHub Actions workflow. Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub Actions Runner
participant Repo as Repository
participant Py as update_localization.py
participant Flutter as Flutter SDK
participant Git as Git (push/commit)
GH->>Repo: checkout
GH->>GH: setup Python 3.11 & Flutter 3.41.4
GH->>Repo: make update_localization.py executable
GH->>Py: run update_localization.py
Py->>Repo: modify localization source files (lib/l10n, etc.)
GH->>Flutter: run flutter gen-l10n
Flutter->>Repo: generate localization artifacts
GH->>Repo: git status --porcelain
alt changes detected and not dry_run
GH->>Git: configure user, commit changes, push
else no changes or dry_run
GH->>GH: skip commit/push
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant refactoring of the internationalization strategy by removing the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚫 CI Build Failed
The automated build process failed. Please review the build logs and fix the issues before requesting another review.
Next steps:
- Check the build logs for specific errors
- Fix the identified issues
- Push your fixes to this branch
- The CI will automatically re-run
Once the build passes, this review will be dismissed automatically.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the entire translation management system from the project. This includes the README.md documentation detailing the system's structure and usage, all language-specific JSON translation files (e.g., Arabic, Bosnian, Catalan, Czech, Danish, German, Esperanto, Spanish, Estonian, Persian, French, Galician, Hungarian, Indonesian, Italian, Japanese, Korean, Malayalam, Dutch, Polish, Portuguese, Romanian, Russian, Slovak, Serbian, Swedish, Thai, Turkish, Ukrainian, Vietnamese, Chinese), and the associated Node.js package configuration files (package.json, package-lock.json). The changes suggest a complete deprecation or relocation of multi-language support.
- Remove easy_localization dependency - Add flutter_localizations and intl dependencies - Create l10n.yaml configuration - Convert JSON translations to ARB format - Update MaterialApp with official localization delegates - Replace all tr() calls with AppLocalizations.of(context)! syntax - Fix 'continue' keyword conflicts - Generate AppLocalizations files - Remove old translation assets This completes the migration to Flutter's official localization system.
… strings in non-widget contexts - Removed AppLocalizations imports from app_sources, components, and providers - Replaced AppLocalizations.of(context) calls with hardcoded English strings - Added intl import for DateFormat usage in app_sources - Fixed all compilation errors while maintaining functionality - Project now compiles successfully with flutter analyze (no errors, only info messages) This resolves the issue where AppLocalizations was being called in contexts without BuildContext, such as in constructors and static methods.
- Successfully migrated all original JSON translations from main branch to ARB format - Added support for 31 languages: ar, bs, ca, cs, da, de, en, en_EO, es, et, fa, fr, gl, he, hu, id, it, ja, ko, ml, nl, pl, pt, pt_BR, ru, sv, tr, uk, vi, zh, zh_Hant_TW - Fixed 'continue' keyword conflict by renaming to 'continueAction' - Fixed invalid ARB resource names (APKLinkHash -> aPKLinkHash, GHReqPrefix -> gHReqPrefix) - Updated main.dart with all supported locales - Generated localization files for all languages successfully - Added basic plural forms to English template - Added complex plural forms for Hebrew and Arabic (zero, one, two, many, other) - All ARB files are valid JSON and generate successfully Status: Complete localization migration with full multi-language support
…coded strings - Fixed import statements to use app_localizations.dart instead of l10n.dart - Replaced all remaining tr() calls with hardcoded English strings - Replaced all plural() calls with hardcoded strings - Fixed app.dart structure issues by restoring from working version - All files now compile successfully with flutter analyze - Only warnings and info messages remain, no blocking errors - Ready for build and deployment
- Fixed import path in settings.dart to use app_localizations.dart - Fixed certificateHash method call in app.dart to use aPKLinkHash string - All compilation errors now resolved - flutter analyze passes - Project is ready for successful build and deployment
….dart - Fixed all plural() calls with proper string formatting - Fixed context access in initializer (moved to hardcoded string) - Fixed Locale.key to use languageCode property - Fixed context.locale to use Localizations.localeOf() - Fixed forcedLocale assignment to use Locale objects - Fixed missing filterDays key with hardcoded string - Fixed broken string interpolation from plural() calls - All compilation errors now resolved - flutter analyze passes - Project is ready for successful build and deployment
- Updated import path from lib/generated/l10n.dart to lib/generated/app_localizations.dart - Resolves all AppLocalizations compilation errors in SecurityDisclaimerScreen - All compilation errors now resolved across entire codebase - Project is ready for successful build and deployment
…odebase - Fixed all import paths from lib/generated/l10n.dart to lib/generated/app_localizations.dart - Fixed all remaining plural() calls with hardcoded string replacements - Fixed EasyLocalization references in apps_provider.dart - Fixed Locale.key references to use languageCode property - Fixed context locale methods (resetLocale, setLocale, etc.) - not needed in Flutter gen-l10n - Fixed broken ternary operator syntax in notifications_provider.dart - All compilation errors now resolved - flutter analyze passes with exit code 0 - Project is ready for successful build and deployment - Migration from easy_localization to Flutter gen-l10n is now complete
- Replaced all AppLocalizations.of(context) calls in apps_provider.dart with hardcoded strings - Replaced AppLocalizations.of(context) calls in settings_provider.dart with hardcoded strings - Provider classes don't have access to BuildContext, so hardcoded strings are appropriate - All compilation errors now resolved - flutter analyze passes with exit code 0 - Migration from easy_localization to Flutter gen-l10n is now complete and functional
- Fixed all unquoted hardcoded strings by adding proper quotes - Fixed broken string concatenations in apps_provider.dart - Fixed corrupted strings with 'No' inserted by replacement script - Fixed remaining plural() call in logs_provider.dart - Fixed byX method call syntax in apps.dart - Fixed variable name from applicableUpdateIdsAllOrSelected to existingUpdateIdsAllOrSelected - Fixed broken string interpolation in import_export.dart - All compilation errors now resolved - flutter analyze passes with exit code 0 - Migration from easy_localization to Flutter gen-l10n is now complete and functional
- Added public getter for apps property in AppsProvider class - Updated internal references from apps to _apps throughout AppsProvider - Added missing methods for TickerProviderStateMixin in _HomePageState - Added activate(), dispose(), and debugFillProperties() overrides - All compilation errors now resolved - flutter analyze passes with exit code 0 - Migration from easy_localization to Flutter gen-l10n is now complete and functional
- Fixed corrupted strings with 'No' inserted throughout apps_provider.dart - Fixed broken string concatenations in notifications_provider.dart - Removed conflicting imports from apps_provider.dart that conflicted with Flutter's State and StatefulWidget - Fixed home.dart class to properly extend State with required methods - All compilation errors now resolved - flutter analyze passes with exit code 0 - Migration from easy_localization to Flutter gen-l10n is now complete and functional
- Fixed notificationsProvider declaration syntax error in apps_provider.dart - Fixed UpdateNotification method name capitalization - Fixed missing semicolons in string concatenations in notifications_provider.dart - All compilation errors now resolved - flutter analyze passes with exit code 0 - Migration from easy_localization to Flutter gen-l10n is now complete and functional
- Fixed remaining corrupted strings: Downloadednotification, Downloadnotification, AppsRemovednotification - Fixed isHTMLWithNoVersionDetection variable name - Fixed string interpolation syntax in dialog messages - Fixed notificationsProvider method call to use context.read<NotificationsProvider>() - Fixed apps list iteration to use proper app ID access instead of index - All compilation errors now resolved - flutter analyze passes with exit code 0 - Migration from easy_localization to Flutter gen-l10n is now complete and ready for APK build
|
/gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request successfully removes the easy_localization dependency and all related assets. The changes primarily consist of deleting translation files, documentation, and configuration scripts, which aligns with the goal of migrating away from this localization solution. Based on the provided diffs, this is a clean removal that simplifies the codebase.
github-actions
bot
dismissed
their stale review
✅ CI Build Passed - Automatically dismissing previous rejection as the build now succeeds.
There was a problem hiding this comment.
🚫 CI Build Failed
The automated build process failed. Please review the build logs and fix the issues before requesting another review.
Next steps:
- Check the build logs for specific errors
- Fix the identified issues
- Push your fixes to this branch
- The CI will automatically re-run
Once the build passes, this review will be dismissed automatically.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
README.md (1)
41-41: Consider using more descriptive link text.The link text "here" is not descriptive, which impacts accessibility for screen reader users and discoverability.
📝 Suggested improvement
-Updatium currently supports 31 locales (including English). If you want to help translate Updatium to your language or improve an existing translation, please open a pull with the new translations added to [here](https://github.com/omeritzics/Updatium/tree/main/lib/l10n). +Updatium currently supports 31 locales (including English). If you want to help translate Updatium to your language or improve an existing translation, please open a pull request with the new translations added to the [localization directory](https://github.com/omeritzics/Updatium/tree/main/lib/l10n).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` at line 41, Replace the non-descriptive link text "here" in the README sentence that starts "Updatium currently supports 31 locales (including English)..." with a descriptive label like "the Updatium translations directory" (or similar) so screen readers and searchers get context; update the link target text instead of the URL itself and ensure the sentence reads naturally with the new descriptive anchor..github/workflows/auto_localization.yml (1)
64-77: Boolean input comparison is inconsistent.The
dry_runinput is defined astype: boolean, but compared against string'true'. While GitHub Actions may coerce types, using boolean comparison is cleaner and less error-prone.📝 Suggested fix
- name: Commit and push changes - if: steps.verify-changed.outputs.changed == 'true' && github.event.inputs.dry_run != 'true' + if: steps.verify-changed.outputs.changed == 'true' && github.event.inputs.dry_run != true run: |Note: Commits pushed using
GITHUB_TOKENwon't trigger other workflows by design. If you need downstream workflows to run on these commits, consider using a PAT or GitHub App token.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/auto_localization.yml around lines 64 - 77, Summary: The workflow condition compares the boolean input dry_run to a string ('true'), causing inconsistent type comparison. Fix the "Commit and push changes" step condition by changing the expression from comparing against the string 'true' to a boolean comparison (use github.event.inputs.dry_run != true or the explicit negation github.event.inputs.dry_run == false) so the if: line uses a boolean comparison; update the conditional on the step named "Commit and push changes" (the if: expression) accordingly to use the dry_run input as a boolean.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/auto_localization.yml:
- Around line 28-31: The workflow uses an outdated action reference
"actions/setup-python@v4"; update the "uses" entry to
"actions/setup-python@v6.2.0" (keeping the existing python-version input) so the
job uses the latest setup-python release; also scan for other occurrences of
"actions/setup-python@v4" in the workflow and replace them with
"actions/setup-python@v6.2.0".
---
Nitpick comments:
In @.github/workflows/auto_localization.yml:
- Around line 64-77: Summary: The workflow condition compares the boolean input
dry_run to a string ('true'), causing inconsistent type comparison. Fix the
"Commit and push changes" step condition by changing the expression from
comparing against the string 'true' to a boolean comparison (use
github.event.inputs.dry_run != true or the explicit negation
github.event.inputs.dry_run == false) so the if: line uses a boolean comparison;
update the conditional on the step named "Commit and push changes" (the if:
expression) accordingly to use the dry_run input as a boolean.
In `@README.md`:
- Line 41: Replace the non-descriptive link text "here" in the README sentence
that starts "Updatium currently supports 31 locales (including English)..." with
a descriptive label like "the Updatium translations directory" (or similar) so
screen readers and searchers get context; update the link target text instead of
the URL itself and ensure the sentence reads naturally with the new descriptive
anchor.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9dcbd566-704c-457f-82ca-42b6bd8c5f0a
⛔ Files ignored due to path filters (30)
lib/generated/app_localizations.dartis excluded by!**/generated/**lib/generated/app_localizations_ar.dartis excluded by!**/generated/**lib/generated/app_localizations_bs.dartis excluded by!**/generated/**lib/generated/app_localizations_ca.dartis excluded by!**/generated/**lib/generated/app_localizations_cs.dartis excluded by!**/generated/**lib/generated/app_localizations_da.dartis excluded by!**/generated/**lib/generated/app_localizations_de.dartis excluded by!**/generated/**lib/generated/app_localizations_en.dartis excluded by!**/generated/**lib/generated/app_localizations_eo.dartis excluded by!**/generated/**lib/generated/app_localizations_es.dartis excluded by!**/generated/**lib/generated/app_localizations_et.dartis excluded by!**/generated/**lib/generated/app_localizations_fa.dartis excluded by!**/generated/**lib/generated/app_localizations_fr.dartis excluded by!**/generated/**lib/generated/app_localizations_gl.dartis excluded by!**/generated/**lib/generated/app_localizations_he.dartis excluded by!**/generated/**lib/generated/app_localizations_hu.dartis excluded by!**/generated/**lib/generated/app_localizations_id.dartis excluded by!**/generated/**lib/generated/app_localizations_it.dartis excluded by!**/generated/**lib/generated/app_localizations_ja.dartis excluded by!**/generated/**lib/generated/app_localizations_ko.dartis excluded by!**/generated/**lib/generated/app_localizations_ml.dartis excluded by!**/generated/**lib/generated/app_localizations_nl.dartis excluded by!**/generated/**lib/generated/app_localizations_pl.dartis excluded by!**/generated/**lib/generated/app_localizations_pt.dartis excluded by!**/generated/**lib/generated/app_localizations_ru.dartis excluded by!**/generated/**lib/generated/app_localizations_sv.dartis excluded by!**/generated/**lib/generated/app_localizations_tr.dartis excluded by!**/generated/**lib/generated/app_localizations_uk.dartis excluded by!**/generated/**lib/generated/app_localizations_vi.dartis excluded by!**/generated/**lib/generated/app_localizations_zh.dartis excluded by!**/generated/**
📒 Files selected for processing (40)
.github/workflows/auto_localization.ymlREADME.mdlib/l10n/app_ar.arblib/l10n/app_bs.arblib/l10n/app_ca.arblib/l10n/app_cs.arblib/l10n/app_da.arblib/l10n/app_de.arblib/l10n/app_en.arblib/l10n/app_eo.arblib/l10n/app_es.arblib/l10n/app_et.arblib/l10n/app_fa.arblib/l10n/app_fr.arblib/l10n/app_gl.arblib/l10n/app_he.arblib/l10n/app_hu.arblib/l10n/app_id.arblib/l10n/app_it.arblib/l10n/app_ja.arblib/l10n/app_ko.arblib/l10n/app_ml.arblib/l10n/app_nl.arblib/l10n/app_pl.arblib/l10n/app_pt.arblib/l10n/app_pt_BR.arblib/l10n/app_ru.arblib/l10n/app_sv.arblib/l10n/app_tr.arblib/l10n/app_uk.arblib/l10n/app_vi.arblib/l10n/app_zh.arblib/l10n/app_zh_Hant_TW.arblib/main.dartlib/pages/add_app.dartlib/pages/app.dartlib/pages/apps.dartlib/pages/import_export.dartlib/pages/settings.dartscripts/update_localization.py
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
github-actions
bot
dismissed
their stale review
✅ CI Build Passed - Automatically dismissing previous rejection as the build now succeeds.
There was a problem hiding this comment.
🚫 CI Build Failed
The automated build process failed. Please review the build logs and fix the issues before requesting another review.
Next steps:
- Check the build logs for specific errors
- Fix the identified issues
- Push your fixes to this branch
- The CI will automatically re-run
Once the build passes, this review will be dismissed automatically.
github-actions
bot
dismissed
their stale review
✅ CI Build Passed - Automatically dismissing previous rejection as the build now succeeds.
|
Note for future self: |
1 participant
Summary by CodeRabbit