fix(visionos): complete mio cfg gating + republish tqdm as onde-tqdm - #8
Merged
Conversation
Point the mio 0.8.11 patch at setoelkahfi/mio@683fca8, which adds the missing `target_os = "visionos"` entries to the kqueue/net/tcp/uds cfg lists. This fixes the `Check (visionOS device)` and `Check (visionOS simulator)` CI jobs that failed with unresolved `Filter`/`Flags`, `sin_len`/`sin6_len`, `SOCK_NONBLOCK`, and `accept4` errors inside mio. Verified locally: cargo +nightly check -Z build-std --target aarch64-apple-visionos cargo +nightly check -Z build-std --target aarch64-apple-visionos-sim Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Record the onde-tqdm migration in the forked-dependencies skill: the crossterm-0.29 tqdm fork is now published to crates.io as `onde-tqdm` and consumed by the mistral.rs fork as a registry rename dep, so it survives cargo publish and reaches onde (the old git dep was stripped). This removes mio 0.8.11 from onde's registry-resolved tree — verified onde resolves mio 1.2.2 only, with the mio patch deleted, when consuming the onde-tqdm-carrying crates. Documents the publish order and that the onde [patch.crates-io] mio entry is deleted once onde bumps to onde-mistralrs 0.9.3+. Also records the removal of the dead core2 patch and the mio official-fork/mio-patch rename. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
paydii
approved these changes
Jul 22, 2026
Bump onde-mistralrs{,-core} from 0.9.2 to 0.9.3 across all platform
sections. 0.9.3 carries the onde-tqdm dependency (crossterm 0.29 -> mio
1.x), so the crates.io tqdm 0.8.0 -> crossterm 0.25 -> mio 0.8.11 chain
that lacked visionOS support is gone from onde's resolved tree.
Delete the [patch.crates-io] mio entry — mio now resolves to 1.2.2 from
the registry. Both aarch64-apple-visionos{,-sim} pass
cargo +nightly check -Z build-std with the patch removed.
Update the forked-dependencies skill to mark the mio fork retired.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the visionOS CI failures (
Check (visionOS device)/(simulator)) and sets up retirement of the temporarymiofork.Changes
a0fd6166): point onde's[patch.crates-io] mioatsetoelkahfi/mio@feature/visionos(683fca8), which completestarget_os = "visionos"cfg gating in kqueue/net/tcp/uds (fixesFilter/Flags,sin_len/sin6_len,SOCK_NONBLOCK,accept4,setup_waker/wakeerrors). Verified withcargo +nightly check -Z build-stdon both visionOS targets.5ee83911): document theonde-tqdmmigration — the crossterm-0.29 tqdm fork is now published to crates.io asonde-tqdmand consumed by the mistral.rs fork as a registry rename dep, removingmio 0.8.11from onde's registry-resolved tree. Records the publish order, the mio-patch retirement plan, and the removedcore2patch.Follow-up (separate, gated on publish)
Once
onde-mistralrs-* 0.9.3(carrying theonde-tqdmdep) is published and onde bumps to it, the[patch.crates-io] mioentry can be deleted entirely — verified onde then resolvesmio 1.2.2only.Related
setoelkahfi/mistral.rs@fix/all-platform-fixes(onde-tqdm dep, core2 removal, 0.9.3 bump)setoelkahfi/tqdm@release/onde-tqdm(publishedonde-tqdm), upstream PR Bumpcrosstermdependency to 0.29 mrlazy1708/tqdm#28setoelkahfi/mio@feature/visionosCo-authored-by: Copilot 223556219+Copilot@users.noreply.github.com