Open
Conversation
ledzep2
commented
Oct 8, 2014
- Remove isolated scope so it can work with other directives
- Add a asFile attribute to retrieve the file as a FileList object instead of dataurl
- Add a dropzoneEnabled attribute so the function can be disabled
- Set a default dropzoneHoverClass "file-dropping"
* Remove isolated scope so it can be attached to other directives.
Member
|
Nice enhancement, for such a component, it would be nice to remove scope isolation. |
Author
|
Yes. It's compatible. And there are two new attributes, asFile and dropzoneEnabled. |
Member
|
This should maybe be a minor point release instead of a patch, since it adds new features. (see http://semver.org/) |
Author
|
good point. any other comments? zao.bi On Tue, Oct 14, 2014 at 5:51 AM, Brian Muse notifications@github.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.