[pull] dev from Flow-Launcher:dev#614
Merged
Merged
Conversation
* Update UrlPattern to include private addresses and update test cases * Fix match logic * Add test case * Fix matching pattern for IPv6 addresses with consecutive ":" * Refactor URL plugin test * Refactor URL match logic * Simplify parsing logic * Fix ipv6 any address and numeric TLD Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Use invariant culture to prevent unintentional IP parsing Some cultures uses comma as decimal separator which escapes this decimal check. Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * Add URL path test coverage to UrlPluginTest (#4307) * Initial plan * Add test cases for URLs with paths Co-authored-by: VictoriousRaptor <10308169+VictoriousRaptor@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: VictoriousRaptor <10308169+VictoriousRaptor@users.noreply.github.com> * Enclose IPv6 addresses in brackets for URL formatting * Don't apply brackets for already closed * Use IPEndPoint to avoid potential URL with IP ports * Ensure IPv6 are bracketed if it's with query or path * Add more url test cases to UrlPluginTest Also update comment on "0.0.0.0" to clarify why its included * Make UrlSchemes the single source of truth for accepted schemes in Url Plugin * Improve comment where http/https scheme is added to urls without one in Url Plugin --------- Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jack Ye <jack1160210343@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: David Brett <davidbrett2002@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )