-
Notifications
You must be signed in to change notification settings - Fork 164
[Access] Update model Block REST API Response #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Update model Block REST API Response #1539
Conversation
| format: uri | ||
| _links: | ||
| $ref: '#/components/schemas/Links' | ||
| block_status: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The block_status field was introduced in flow-go's model_block.go but was missing here. This addition ensures consistency between the two models.
For reference, the commit where block_status was added to flow-go: commit
| - BLOCK_UNKNOWN | ||
| - BLOCK_FINALIZED | ||
| - BLOCK_SEALED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for reference, these are defined here
issue: onflow/flow-go#6874
Context
In this PR the
openAPIwas updated:omitemptytag was added to theExpandablefield forBlock,block_statusfield was added forBlock