Skip to content

Conversation

@UlyanaAndrukhiv
Copy link
Contributor

@UlyanaAndrukhiv UlyanaAndrukhiv commented Jan 13, 2025

issue: onflow/flow-go#6874

Context

In this PR the openAPI was updated:

  • the omitempty tag was added to the Expandable field for Block,
  • the block_status field was added for Block

@UlyanaAndrukhiv UlyanaAndrukhiv self-assigned this Jan 13, 2025
@UlyanaAndrukhiv UlyanaAndrukhiv marked this pull request as ready for review January 14, 2025 09:36
format: uri
_links:
$ref: '#/components/schemas/Links'
block_status:
Copy link
Contributor Author

@UlyanaAndrukhiv UlyanaAndrukhiv Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The block_status field was introduced in flow-go's model_block.go but was missing here. This addition ensures consistency between the two models.

For reference, the commit where block_status was added to flow-go: commit

@Guitarheroua Guitarheroua self-assigned this Jan 22, 2025
Comment on lines +940 to +942
- BLOCK_UNKNOWN
- BLOCK_FINALIZED
- BLOCK_SEALED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for reference, these are defined here

@peterargue peterargue merged commit 1d81c28 into onflow:master Jan 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants