Updating symlink target to be the basename of the specified folder#1
Open
ronyis wants to merge 1 commit intoonlicar:masterfrom
Open
Updating symlink target to be the basename of the specified folder#1ronyis wants to merge 1 commit intoonlicar:masterfrom
ronyis wants to merge 1 commit intoonlicar:masterfrom
Conversation
Contributor
|
If you use this library, please fork it, as I doubt it will be maintained in the future. I have left this GitHub organisation. |
Author
|
Ok, thanks |
|
@danbovey thanks for jumping in and commenting!! :) |
|
@danbovey @adamonlicar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the plugin supports folders that looks like
../../../<name>, but if the folder needed to include is under a subfolder it won't work.For example, if the folder to include is
../service1/utils/the created symlink target will beservice1utils.To fix that, the basename of given folder should be used (the behavior for paths as supported before won't change).