Skip to content

s3 uploads #543#659

Open
metame wants to merge 5 commits intoontola:developfrom
metame:543-s3-uploads
Open

s3 uploads #543#659
metame wants to merge 5 commits intoontola:developfrom
metame:543-s3-uploads

Conversation

@metame
Copy link
Copy Markdown
Contributor

@metame metame commented Sep 5, 2023

PR Checklist:

Open issues:

  1. The data browser preview is currently not working for s3 files. This is likely because the download endpoint does a 302 temporary redirect to a S3 signed URL. I'd be happy to open a new issue for this for someone to fix that is familiar with the client side code.
  2. Currently the config only requires S3 bucket to be specified. This is in line with opendal's requirements. The main callout here is that we are depending on opendal's default for region, which is "us-east-1". I could specify this directly in atomic's source code or we can make this a required config value.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants