Extend preset tours to recorded tours.#735
Conversation
| @@ -1734,7 +1727,8 @@ Add GeoMove</revremark> | |||
| </section> | |||
| <section> | |||
| <title>Preset Tour Operations</title> | |||
There was a problem hiding this comment.
Should this section now be named Tour Operations?
- Rename new ExtendedPTZPresetOperations to PTZTourOperations. - Make operation extensible.
| @@ -1941,7 +1946,10 @@ Add GeoMove</revremark> | |||
| <para>Stop: indicates stopping the preset tour.</para> | |||
There was a problem hiding this comment.
| <para>Stop: indicates stopping the preset tour.</para> | |
| <para>Stop: indicates stopping the preset tour or the recording.</para> |
There was a problem hiding this comment.
Because the device can have a limitation on the number of recorded tours, we should have a capability. This allows a better user experience for the client by preventing the action instead of handling an error when we start the recording.
There was a problem hiding this comment.
Add a fault if maximum number of recordings is reached.
- Add separate PTZ node information about supported number of recorded tours. - Streamline requirements.
…ypes. Revert extension of tour-operations as now original set is sufficient.
| @@ -1806,14 +1814,16 @@ Add GeoMove</revremark> | |||
| <varlistentry> | |||
| <term>access class</term> | |||
| <listitem> | |||
| <para role="access">READ_MEDIA</para> | |||
| <para role="access">READ_MEDIA </para> | |||
There was a problem hiding this comment.
revert space
| <para role="access">READ_MEDIA </para> | |
| <para role="access">READ_MEDIA</para> |
| @@ -1806,14 +1814,16 @@ Add GeoMove</revremark> | |||
| <varlistentry> | |||
| <term>access class</term> | |||
| <listitem> | |||
| <para role="access">READ_MEDIA</para> | |||
| <para role="access">READ_MEDIA </para> | |||
| </listitem> | |||
| </varlistentry> | |||
| </variablelist> | |||
| </section> | |||
| <section> | |||
| <title>GetPresetTourOptions</title> | |||
There was a problem hiding this comment.
Add GetRecordedTourOptions for AutoStart and recurring time ?
| </listitem> | ||
| <listitem> | ||
| <para>Pause:iIndicates pausing the preset tour.</para> | ||
| <para>Record: start an new recording and override any existing recording.</para> |
There was a problem hiding this comment.
Record operation is no longer needed.
There was a problem hiding this comment.
@cemond-genetec better to keep for backword compatability.
kieran242
left a comment
There was a problem hiding this comment.
Some minor comments :)
| @@ -420,6 +412,10 @@ Add GeoMove</revremark> | |||
| <listitem> | |||
| <para>MaximumNumberOfPresetTours – Indicates number of preset tours that can be created. Required preset tour operations shall be available for this PTZ node if one or more preset tours are supported.</para> | |||
| </listitem> | |||
| <listitem> | |||
| <para>MaxRecordedTours - Indicatesthe maximum number of recorded tours that can be | |||
There was a problem hiding this comment.
| <para>MaxRecordedTours - Indicatesthe maximum number of recorded tours that can be | |
| <para>MaxRecordedTours - Indicates the maximum number of recorded tours that can be |
| @@ -1885,9 +1897,54 @@ Add GeoMove</revremark> | |||
| </varlistentry> | |||
| </variablelist> | |||
| </section> | |||
| <section> | |||
| <title>RecordTour</title> | |||
| <para>Create an recorded tour or overwrite an existing tour. Finish the recording with tour | |||
There was a problem hiding this comment.
| <para>Create an recorded tour or overwrite an existing tour. Finish the recording with tour | |
| <para>Create a recorded tour or overwrite an existing tour. Finish the recording with tour |
| </listitem> | ||
| <listitem> | ||
| <para>Pause:iIndicates pausing the preset tour.</para> | ||
| <para>Record: start an new recording and override any existing recording.</para> |
There was a problem hiding this comment.
@cemond-genetec better to keep for backword compatability.
kieran242
left a comment
There was a problem hiding this comment.
@HansBusch I have reviewed the same and have not seen anything that would jump out at me as critical issues. I have agreed with @cemond-genetec points were raised.
| @@ -1146,6 +1172,11 @@ If no stop argument for pan, tilt or zoom is set, the device will stop all ongoi | |||
| <wsdl:input message="tptz:CreatePresetTourRequest"/> | |||
| <wsdl:output message="tptz:CreatePresetTourResponse"/> | |||
| </wsdl:operation> | |||
| <wsdl:operation name="RecordTour"> | |||
| <wsdl:documentation>Start recording of a new recorded tour or start overwriting an existing tour.</wsdl:documentation> | |||
| <wsdl:input message="tptz:RecordTourRequest"/> | |||
There was a problem hiding this comment.
How to stop the recording of a recording tour? Is client needs to use OperatePresetTour for play of the record tour i.e PTZPresetTourOperation - Start and for stop the playing record tour - PTZPresetTourOperation Stop.
| @@ -5137,6 +4770,11 @@ decoding .A decoder shall decode every data it receives (according to its capabi | |||
| <xs:documentation>Unique identifier of this preset tour.</xs:documentation> | |||
| </xs:annotation> | |||
| </xs:attribute> | |||
| <xs:attribute name="IsRecorded" type="xs:boolean"> | |||
There was a problem hiding this comment.
As per PTZ Wsdl with onvif.xsd, IsRecorded is mandatory parameter in ModifyPresetTour client request which creates backward compatibility issue.
There was a problem hiding this comment.
I believe attributes are optional by default so I don't think it would cause any backward issues.
Alternative proposal to supporting recording tours.