Add attribute to signal estimated TLS activation time.#740
Open
HansBusch wants to merge 2 commits into
Open
Conversation
bsriramprasad
requested changes
Mar 13, 2026
| </xs:attribute> | ||
| <xs:attribute name="SetupDuration" type="xs:duration"> | ||
| <xs:annotation> | ||
| <xs:documentation>Indication how long a change to the TLS server settings need to be activated.</xs:documentation> |
Contributor
There was a problem hiding this comment.
Suggested change
| <xs:documentation>Indication how long a change to the TLS server settings need to be activated.</xs:documentation> | |
| <xs:documentation>Indicates the maximum time taken for updated TLS server settings to take effect.</xs:documentation> |
Contributor
There was a problem hiding this comment.
@cappentz suggests to add 'maximum' time it takes
Contributor
There was a problem hiding this comment.
@HansBusch I agree with this comment update also.
Contributor
|
@HansBusch it would be good if you could add a description to the PR. Kind thanks |
Collaborator
|
@HansBusch I am a bit lost on this PR. In what state is this? Are you still targeting 26.06 or can we move this to 26.12? |
Member
Author
We didn't close last week. Hence I suggest to defer to 26.12. |
| </row> | ||
| <row> | ||
| <entry>SetupDuration</entry> | ||
| <entry><para>Indication how long a change to the TLS server configuration needs to be activated.</para></entry> |
Contributor
There was a problem hiding this comment.
- It is ambiguous whether the value means:
- time until the change becomes active, or
- time for which the change remains active, or
- time required after activation
Suggested change
| <entry><para>Indication how long a change to the TLS server configuration needs to be activated.</para></entry> | |
| <entry><para>Indicates how long a TLS server configuration change takes to become effective..</para></entry> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.