Improve firmware upgrade timing description and notification.#780
Open
HansBusch wants to merge 1 commit into
Open
Improve firmware upgrade timing description and notification.#780HansBusch wants to merge 1 commit into
HansBusch wants to merge 1 commit into
Conversation
…riod update progress events.
ocampana-videotec
requested changes
Jun 1, 2026
ocampana-videotec
left a comment
ocampana-videotec
left a comment
Collaborator
There was a problem hiding this comment.
It's just a trivial correction, the rest looks good to me.
| <listitem> | ||
| <para role="param">ExpectedDownTime [xs:duration]</para> | ||
| <para role="text">A duration that indicates how long the device expects to be unavailable after the firmware upload is complete.</para> | ||
| <para role="text">An indication how long the device expects to be unavailable.</para> |
Collaborator
There was a problem hiding this comment.
An indication of how
mfournier-genetec
left a comment
mfournier-genetec
left a comment
Contributor
There was a problem hiding this comment.
Once the comment from @ocampana-videotec is resolved I will approve this changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve wording of downtime estimation.
Add recommendation to send periodic update progress events.
We can see three different types of upgrade mechanism. As all of them are opaque to the client, the responses and notifications should fit to all of them: