Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,8 @@ The other way is using the provided helm chart for the project under `./deploy`
To do this, use the following command:

```bash
helm install ocm-controller oci://ghcr.io/open-component-model/helm/ocm-controller --version v0.25.3
OCM_CONTROLLER_LATEST_VERSION=$(curl -s https://api.github.com/repos/open-component-model/ocm-controller/releases/latest | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OCM_CONTROLLER_LATEST_VERSION=$(curl -s https://api.github.com/repos/open-component-model/ocm-controller/releases/latest | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/')
OCM_CONTROLLER_LATEST_VERSION=$(curl -s https://api.github.com/repos/open-component-model/ocm-controller/releases/latest | jq -r '.tag_name')

Although I really love some sed action, I think using jq is simpler (however, it would be another dependency)

helm install ocm-controller oci://ghcr.io/open-component-model/helm/ocm-controller --version $OCM_CONTROLLER_LATEST_VERSION
```

This does require that certain items, like certificate secrets are pre-created by the user.
Expand Down
Loading