fix: run testbed image as root to support bind-mounted /flags - #383
Conversation
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
|
Warning Review limit reached
Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe testbed Docker image no longer creates a non-root user or changes directory ownership. It intentionally runs as root so launchpad-generated flag configurations can be written to ChangesTestbed container execution
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Removed comments about running as root in Dockerfile. Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
The non-root change in #381 (v3.8.1) breaks consumers that bind-mount a host
/flagsdir: launchpad runs astestbedand cannot writeallFlags.jsoninto the root-owned mount, so the container exits 1 (surfaced in flagd's e2e). Reverting to root; the busybox-root Sonar hotspot should be marked Safe since this is a test fixture that must write to consumer-provided bind mounts of arbitrary ownership.