Skip to content

fix: minor security hardening #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toddbaert merged 2 commits into from
Jul 24, 2026
Merged

fix: minor security hardening #416

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4741e99
chore: minor security hardening
toddbaert Jul 24, 2026
d144658
fixup: resolve symlinks in path validation
toddbaert Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion tools/specification_parser/lint_json_output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,21 @@
from os.path import curdir, abspath, join, splitext
from os.path import curdir, abspath, realpath, join, splitext, commonpath
from os import walk
import json
import sys


def _safe_path(f):
# resolve symlinks and reject paths that escape the current working directory
base = realpath(curdir)
target = realpath(f)
if commonpath([base, target]) != base:
print(f"Refusing to read path outside {base}: {f}", file=sys.stderr)
sys.exit(1)
return target


def main(f):
f = _safe_path(f)
errors = 0
with open(f) as jsonfile:
spec = json.load(jsonfile)
Expand Down
Loading