chore: resolve open dependabot security alerts - #418
Conversation
📝 WalkthroughWalkthrough
ChangesMaintenance updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates JavaScript devDependencies/lockfile to address open Dependabot security alerts affecting transitive packages used by the markdown linting/tooling workflow.
Changes:
- Bumped
markdownlint-clidevDependency from^0.49.0to^0.49.1. - Updated
package-lock.jsonto pull patched transitive versions (includinglinkify-it,js-yaml, andbrace-expansion) and related dependency bumps.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Bumps markdownlint-cli to ^0.49.1 to pick up patched transitive dependencies. |
| package-lock.json | Refreshes the lockfile with updated transitive dependency versions (including security-related updates). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Addresses Copilot review feedback on PR #418: markdownlint-cli 0.49.1's transitive deps (e.g. ini) require Node >=22, so declare engines.node to make the requirement explicit for contributors. Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
The dead CNCF Slack invite link is fixed properly in a separate PR. Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
- ip-address: add npm override to >=10.2.2 (alerts #37, #38, high/medium SSRF bypass) - re-add markdown-link-check ignore for dead CNCF invite link since the proper README fix (PR #419) has not merged to main yet; without this, make lint fails on this branch Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Pull request was converted to draft
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.markdown-link-check-config.json:11
- This unrelated exemption changes
markdown-link-checkbehavior by permanently skipping the existing CNCF invite link inspecification/appendix-c/index.md:19, although the PR is described as a dependency-only security update whose checks behave identically to main. Please remove it from this PR, or separately document why this URL must no longer be validated.
{
"pattern": ".*communityinviter.com/apps/cloud-native/cncf.*"
Addresses Copilot review feedback on the previous commit: rather than permanently exempting the dead communityinviter.com link from markdown-link-check, update it to the live https://slack.cncf.io/ redirect (same fix as #419), so link validation stays intact. Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Summary
Dependabot Alerts Resolved
ip-address>=10.2.2(transitive, via markdown-link-check -> proxy-agent -> socks-proxy-agent -> socks)ip-addresslinkify-itjs-yamlbrace-expansionNo changes to production code; devDependencies and lockfile only, plus the one-line dead-link fix noted above. Verified
npm auditreports 0 vulnerabilities for the packages listed above, andmake lint/make markdown-tocpass locally matching CI behavior.