Skip to content

fix: replace execSync string interpolation with execFileSync to prevent command injection #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreyas-lyzr merged 1 commit into from
Mar 25, 2026
Merged

fix: replace execSync string interpolation with execFileSync to prevent command injection #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/utils/git-cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { existsSync, mkdirSync, rmSync, readdirSync } from 'node:fs';
import { join } from 'node:path';
import { createHash } from 'node:crypto';
import { homedir, tmpdir } from 'node:os';
import { execSync } from 'node:child_process';
import { execFileSync } from 'node:child_process';

export interface ResolveRepoOptions {
branch?: string;
Expand Down Expand Up @@ -31,7 +31,7 @@ function isDirEmpty(dir: string): boolean {

function detectDefaultBranch(url: string): string {
try {
const output = execSync(`git ls-remote --symref ${url} HEAD`, {
const output = execFileSync('git', ['ls-remote', '--symref', url, 'HEAD'], {
encoding: 'utf-8',
stdio: ['pipe', 'pipe', 'pipe'],
timeout: 15_000,
Expand Down Expand Up @@ -92,7 +92,7 @@ export function resolveRepo(url: string, options: ResolveRepoOptions = {}): Reso

function cloneRepo(url: string, branch: string, dir: string): void {
mkdirSync(dir, { recursive: true });
execSync(`git clone --depth 1 --branch ${branch} ${url} ${dir}`, {
execFileSync('git', ['clone', '--depth', '1', '--branch', branch, url, dir], {
stdio: 'pipe',
});
}
12 changes: 6 additions & 6 deletions src/utils/registry-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { existsSync, mkdirSync, cpSync, readFileSync, writeFileSync } from 'node:fs';
import { existsSync, mkdirSync, rmSync, cpSync, readFileSync, writeFileSync } from 'node:fs';
import { join, resolve } from 'node:path';
import { execSync } from 'node:child_process';
import { execFileSync } from 'node:child_process';

export interface RegistryConfig {
name: string;
Expand Down Expand Up @@ -186,22 +186,22 @@ export class GitHubProvider implements SkillRegistryProvider {
// Clone and extract specific path
const tmpDir = join(targetDir, '.tmp-git-clone');
try {
execSync(`git clone --depth 1 --filter=blob:none --sparse https://github.com/${repo}.git "${tmpDir}"`, { stdio: 'pipe' });
execSync(`git -C "${tmpDir}" sparse-checkout set "${subPath}"`, { stdio: 'pipe' });
execFileSync('git', ['clone', '--depth', '1', '--filter=blob:none', '--sparse', `https://github.com/${repo}.git`, tmpDir], { stdio: 'pipe' });
execFileSync('git', ['-C', tmpDir, 'sparse-checkout', 'set', subPath], { stdio: 'pipe' });
const skillName = subPath.split('/').pop()!;
const skillDir = join(targetDir, skillName);
mkdirSync(skillDir, { recursive: true });
cpSync(join(tmpDir, subPath), skillDir, { recursive: true });
} finally {
if (existsSync(tmpDir)) {
execSync(`rm -rf "${tmpDir}"`, { stdio: 'pipe' });
rmSync(tmpDir, { recursive: true, force: true });
}
}
} else {
// Clone entire repo as a skill
const skillName = repo.split('/').pop()!;
const skillDir = join(targetDir, skillName);
execSync(`git clone --depth 1 https://github.com/${repo}.git "${skillDir}"`, { stdio: 'pipe' });
execFileSync('git', ['clone', '--depth', '1', `https://github.com/${repo}.git`, skillDir], { stdio: 'pipe' });
}
}
}
Expand Down