Add members to Group and add Group Type restriction hints#40
Draft
Add members to Group and add Group Type restriction hints#40
Conversation
swennemers
reviewed
Dec 16, 2025
swennemers
reviewed
Dec 16, 2025
swennemers
reviewed
Dec 16, 2025
swennemers
reviewed
Dec 16, 2025
Comment on lines
+3903
to
+3934
| restrictDirection: | ||
| type: string | ||
| oneOf: | ||
| - const: "resource-to-group" | ||
| description: |- | ||
| The resource is assigned to the group. | ||
| - const: "group-to-resource" | ||
| description: |- | ||
| The group is assigned to the resource. | ||
| description: |- | ||
| Optionally restricts the direction of the group assignments for this group type. | ||
| x-introduced-in-version: "1.13.0" | ||
| x-feature-status: beta | ||
|
|
||
| restrictResourceType: | ||
| type: array | ||
| description: |- | ||
| Optionally restricts group assignments (of this group type) to ORD resource types. | ||
| items: | ||
| type: string | ||
| enum: | ||
| - "package" | ||
| - "consumptionBundle" | ||
| - "apiResource" | ||
| - "eventResource" | ||
| - "capability" | ||
| - "entityType" | ||
| - "integrationDependency" | ||
| - "dataProduct" | ||
| x-introduced-in-version: "1.13.0" | ||
| x-feature-status: beta | ||
|
|
Member
There was a problem hiding this comment.
I have the feeling, that we are getting too complicated with this and I would leave it out.
Member
Author
There was a problem hiding this comment.
Yes, I have a similar feeling. I added it here because we discussed it. But we can decide to not do it for now, maybe keep it commented-out.
Member
|
There is the probably overlapping requirement to introduce an explicit taxonomy/group assignment resource, as these assignments can have a different lifecycle than the ORD resource and also the taxonomy. So, I am wondering, if we should introduce members or if this would be better covered with a taxonomy/group assignment ORD resource. |
Co-authored-by: Sebastian Wennemers <sebastian.wennemers@sap.com>
Co-authored-by: Sebastian Wennemers <sebastian.wennemers@sap.com>
Co-authored-by: Sebastian Wennemers <sebastian.wennemers@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
membersassignment from a Group to ORD ResourcespartOfGroupsassignment, assuming they know which group (instances) they belong tomembers), not vice versarestrictDirectionto optionally restrict the direction of group assignments to either resource -> group or vice versa.restrictResourceTypeto optionally restrict group assignments to one or more ORD resource types.@swennemers I'm least sure about
restrictDirectionif we really need this. Also we could leave outrestrictResourceTypefor now. It might help with validation of correct use of taxonomy later, though.