extension smoke test to avoid regression with indy #15497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstrumentation into extensions-examples-indy
SylvainJuge
commented
Dec 1, 2025
| private static final String appPath = | ||
| System.getProperty("io.opentelemetry.smoketest.extension.testapp.path"); | ||
|
|
||
| private static final String IMAGE = "eclipse-temurin:21"; |
Contributor
Author
There was a problem hiding this comment.
[for reviewer] for now we only test with a single rather recent JVM, as far as I know we don't have things that might be influenced by the JVM version that relate to indy instrumentation.
Comment on lines
84
to
97
| List<String> appOutput = | ||
| Arrays.asList(target.getLogs(OutputFrame.OutputType.STDOUT).split("\n")); | ||
| assertThat(appOutput) | ||
| .describedAs("return value instrumentation") | ||
| .contains("return value has been modified"); | ||
| assertThat(appOutput) | ||
| .describedAs("argument value instrumentation") | ||
| .contains("argument has been modified"); | ||
| assertThat(appOutput) | ||
| .describedAs("virtual field support") | ||
| .contains("virtual field supported"); | ||
| assertThat(appOutput) | ||
| .describedAs("local advice variable support") | ||
| .contains("local advice variable supported"); |
Contributor
Author
There was a problem hiding this comment.
[for reviewer] I know parsing the output can be brittle, but the application is elementary so this should be fine.
…nstrumentation into extensions-examples-indy
SylvainJuge
changed the title
…nstrumentation into extensions-examples-indy
…nstrumentation into extensions-examples-indy
…nstrumentation into extensions-examples-indy
12 tasks
…nstrumentation into extensions-examples-indy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13031
In order to help with transition to indy instrumentation, we need proper tests for extensions:
This PR adds:
The goal of this PR is to add testing for the "current state" of existing extensions, which should be able to run without any modification.
Tested instrumentation features
How to run
io.opentelemetry.smoketest.ExtensionsSmokeTestin the IDE