Skip to content

Only throw Invalid resposne exception if grpc response is < 5 #8194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jack-berg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Only throw Invalid resposne exception if grpc response is < 5 #8194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...http/src/main/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpGrpcSender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ public byte[] getResponseMessage() {
}

private static byte[] getResponseMessageBytes(byte[] bodyBytes) throws IOException {
if (bodyBytes.length > 5) {
if (bodyBytes.length >= 5) {
Copy link
Member Author

@jack-berg jack-berg Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laurit notes that for a typical case where an OTLP receiver returns an empty payload, this results in IOException("Invalid response"). Added in #8046.

This error didn't show up in our build logs because it results in a log at level FINE.

ByteArrayInputStream bodyStream = new ByteArrayInputStream(bodyBytes);
bodyStream.skip(5);
if (bodyBytes[0] == 1) {
Expand Down
6 changes: 3 additions & 3 deletions ...rc/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ private static void onError(Throwable e) {
}
}

private static Sampler updateSampler(SamplingStrategyResponse response) {
private static Sampler updateSampler(SamplingStrategyResponse response) throws IOException {
SamplingStrategyResponse.PerOperationSamplingStrategies operationSampling =
response.perOperationSamplingStrategies;
if (operationSampling.strategies.size() > 0) {
Expand All @@ -156,9 +156,9 @@ private static Sampler updateSampler(SamplingStrategyResponse response) {
return Sampler.parentBased(
new RateLimitingSampler(response.rateLimitingSamplingStrategy.maxTracesPerSecond));
case UNRECOGNIZED:
throw new AssertionError("unrecognized sampler type");
throw new IOException("unrecognized sampler type");
}
throw new AssertionError("unrecognized sampler type");
throw new IOException("unrecognized sampler type");
}

@Override
Expand Down
20 changes: 20 additions & 0 deletions ...est/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSamplerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,26 @@ void pollingInterval_duration() {
}
}

@Test
void emptyResponse() {
Sampling.SamplingStrategyResponse response =
Sampling.SamplingStrategyResponse.newBuilder().build();
responses.add(response);

try (JaegerRemoteSampler sampler =
JaegerRemoteSampler.builder()
.setEndpoint(server.httpUri().toString())
.setServiceName(SERVICE_NAME)
// Make sure only polls once.
.setPollingInterval(500, TimeUnit.SECONDS)
.build()) {
assertThat(sampler).extracting("grpcSender").isInstanceOf(OkHttpGrpcSender.class);

// Empty response results in an unmarshaling exception which is handled by logging a warning
await().untilAsserted(() -> logs.assertContains("Failed to unmarshal strategy response"));
}
}

@Test
void perOperationSampling() {
Sampling.SamplingStrategyResponse response =
Expand Down
20 changes: 20 additions & 0 deletions ...io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSamplerGrpcNettyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,26 @@ void pollingInterval_duration() {
}
}

@Test
void emptyResponse() {
Sampling.SamplingStrategyResponse response =
Sampling.SamplingStrategyResponse.newBuilder().build();
responses.add(response);

try (JaegerRemoteSampler sampler =
JaegerRemoteSampler.builder()
.setChannel(managedChannel())
.setServiceName(SERVICE_NAME)
// Make sure only polls once.
.setPollingInterval(500, TimeUnit.SECONDS)
.build()) {
assertThat(sampler).extracting("grpcSender").isInstanceOf(UpstreamGrpcSender.class);

// Empty response results in an unmarshaling exception which is handled by logging a warning
await().untilAsserted(() -> logs.assertContains("Failed to unmarshal strategy response"));
}
}

@Test
void perOperationSampling() {
Sampling.SamplingStrategyResponse response =
Expand Down
Loading