Fix dead API reference in rationale.md try-with-resources example#8488
Merged
jack-berg merged 1 commit intoJun 22, 2026
Merged
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8488 +/- ##
=========================================
Coverage 78.77% 78.77%
Complexity 8579 8579
=========================================
Files 1009 1009
Lines 28993 28993
Branches 3599 3599
=========================================
Hits 22839 22839
Misses 5311 5311
Partials 843 843 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/easycla |
Contributor
|
Thank you for your contribution @thswlsqls! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closeable" example indocs/rationale.mdcallsTracingContextUtils.currentContextWith(span). Neither that class nor thecurrentContextWithmethod exists in the codebase (confirmed viagrep), so copy-pasting the example does not compile.Span extends ImplicitContextKeyed,span.makeCurrent()returns aScope— the current API that fits try-with-resources directly.docs/sdk-configuration-design.mdalready uses thetry (Scope ignored = span.makeCurrent())pattern; this PR aligns the example with it.Testing done
docs/rationale.md). No behavior change → no new tests, not a Gradle build target.context/.../ImplicitContextKeyed.javathatspan.makeCurrent()returnsScope, matching the example'stry (Scope scope = ...).