Skip to content

Fix OtlpGrpcProfileExporter toString class name #8492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thswlsqls wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

Fix OtlpGrpcProfileExporter toString class name #8492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ofiles/src/main/java/io/opentelemetry/exporter/otlp/profiles/OtlpGrpcProfileExporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public CompletableResultCode shutdown() {

@Override
public String toString() {
StringJoiner joiner = new StringJoiner(", ", "OtlpGrpcProfilesExporter{", "}");
StringJoiner joiner = new StringJoiner(", ", "OtlpGrpcProfileExporter{", "}");
joiner.add(builder.toString(false));
return joiner.toString();
}
Expand Down
7 changes: 7 additions & 0 deletions ...es/src/test/java/io/opentelemetry/exporter/otlp/profiles/OtlpGrpcProfileExporterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ void usingOkHttp() throws Exception {
}
}

@Test
void stringRepresentationClassName() {
try (OtlpGrpcProfileExporter exporter = OtlpGrpcProfileExporter.builder().build()) {
assertThat(exporter.toString()).startsWith("OtlpGrpcProfileExporter{");
}
}

@Test
@Override // whilst profile signal type is in development it uses a different error message
@SuppressLogger(GrpcExporter.class)
Expand Down
Loading