Fix sign extension on LogRecord flags in low-allocation log marshaler#8493
Draft
thswlsqls wants to merge 1 commit into
Draft
Fix sign extension on LogRecord flags in low-allocation log marshaler#8493thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8493 +/- ##
=========================================
Coverage 78.77% 78.77%
Complexity 8579 8579
=========================================
Files 1009 1009
Lines 28993 28993
Branches 3599 3599
=========================================
Hits 22839 22839
Misses 5311 5311
Partials 843 843 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
LogStatelessMarshalerpasses theTraceFlagsbytedirectly into theint-takingserializeFixed32/sizeFixed32forLogRecord.flags, so a flags byte with the high bit set sign-extends.0x80is then written little-endian as80 FF FF FFinstead of80 00 00 00, and the JSON renders the sign-extended integer. fixed32 is always 4 bytes, so the size is unaffected — only the byte/JSON content is wrong.serializeByteAsFixed32/sizeByteAsFixed32, which mask((int) value) & 0xff, matching the non-stateless siblingLogMarshaler(lines 121, 156).Testing done
SPAN_CONTEXTinLowAllocationLogRequestMarshalerTesttoTraceFlags.fromByte((byte) 0x80), so the existing relative assertions (validateOutput,validateJsonOutput) compare the stateless and non-stateless paths with the high bit set. Both fail before the fix and pass after../gradlew :exporters:otlp:common:checkpassed (118 tests).docs/apidiffs/change. Added a## UnreleasedCHANGELOG.mdentry under SDK > Exporters.