Skip to content

Fix Javadoc and comment in OSGi integration tests #8500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thswlsqls wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Draft

Fix Javadoc and comment in OSGi integration tests #8500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...Config/java/io/opentelemetry/integrationtest/osgi/AutoconfigureDeclarativeConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ void declarativeConfigSdkInitializes(@TempDir Path tempDir) throws IOException {
Path configFile = tempDir.resolve("otel-config.yaml");
Files.write(configFile, yaml.getBytes(StandardCharsets.UTF_8));

// System.setProperty is required: addPropertiesSupplier because property suppliers are not
// resolved until after otel.config.file check
// System.setProperty (not addPropertiesSupplier) is required because property suppliers are
// not resolved until after the otel.config.file check.
System.setProperty("otel.config.file", configFile.toString());
AutoConfiguredOpenTelemetrySdk autoConfigured;
try {
Expand Down
1 change: 1 addition & 0 deletions ...ts/osgi/src/testSdk/java/io/opentelemetry/integrationtest/osgi/OpenTelemetryOsgiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import org.junit.jupiter.api.extension.ExtendWith;
import org.osgi.test.junit5.context.BundleContextExtension;

/** Verifies the SDK (traces, metrics, logs) and Context API work in OSGi. */
@ExtendWith(BundleContextExtension.class)
public class OpenTelemetryOsgiTest {

Expand Down
Loading