Skip to content

Fix OpenTelemetrySdkBuilderUtil.setConfigProvider Javadoc copy-paste#8502

Draft
thswlsqls wants to merge 1 commit into
open-telemetry:mainfrom
thswlsqls:docs/sdkbuilderutil-setconfigprovider-javadoc
Draft

Fix OpenTelemetrySdkBuilderUtil.setConfigProvider Javadoc copy-paste#8502
thswlsqls wants to merge 1 commit into
open-telemetry:mainfrom
thswlsqls:docs/sdkbuilderutil-setconfigprovider-javadoc

Conversation

@thswlsqls

Copy link
Copy Markdown
Contributor

Description

  • OpenTelemetrySdkBuilderUtil.setConfigProvider carried a copy-pasted Javadoc reading "Reflectively set the {@link ScopeConfigurator} to the {@link SdkTracerProvider}", but the method sets a SdkConfigProvider on the OpenTelemetrySdkBuilder.
  • ScopeConfigurator was never imported here, so the {@link} was a dead reference, and the SdkTracerProvider import existed only to resolve that broken link.
  • Corrected the Javadoc to reference SdkConfigProvider and OpenTelemetrySdkBuilder (both already imported) and removed the now-unused SdkTracerProvider import.
  • The sibling Sdk{Tracer,Meter,Logger}ProviderUtil classes carry the same sentence correctly because they import and operate on ScopeConfigurator; this internal util just inherited the wording.

Testing done

  • Docs-only (internal package), test-exempt: no test added; behavior, signature, and public API are unchanged.
  • ./gradlew :sdk:all:check passed (jApiCmp, checkstyle, ErrorProne/NullAway, tests).
  • Internal package (japicmp untracked) → no docs/apidiffs update; not user-facing → no CHANGELOG.md entry.

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.78%. Comparing base (824334c) to head (b2048ff).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8502      +/-   ##
============================================
+ Coverage     78.77%   78.78%   +0.01%     
  Complexity     8579     8579              
============================================
  Files          1009     1009              
  Lines         28993    28993              
  Branches       3599     3599              
============================================
+ Hits          22839    22843       +4     
+ Misses         5311     5308       -3     
+ Partials        843      842       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant