Fix ReadWriteLogRecord default getObservedTimestampEpochNanos returning record timestamp#8504
Draft
thswlsqls wants to merge 1 commit into
Draft
Conversation
…ng record timestamp
299c092 to
aa6aec0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8504 +/- ##
=========================================
Coverage 78.77% 78.77%
- Complexity 8579 8580 +1
=========================================
Files 1009 1009
Lines 28993 28993
Branches 3599 3599
=========================================
Hits 22839 22839
+ Misses 5311 5310 -1
- Partials 843 844 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8501
Description
ReadWriteLogRecord.getObservedTimestampEpochNanos()default returnedtoLogRecordData().getTimestampEpochNanos()instead ofgetObservedTimestampEpochNanos(), so implementations relying on the interface defaults got the record timestamp instead of the observed timestamp.SdkReadWriteLogRecord.getObservedTimestampEpochNanos(), which returns theobservedTimestampEpochNanosfield, and the sibling defaultgetTimestampEpochNanos(), which is correct.LogRecordDataexposes both getters separately.Testing done
ReadWriteLogRecordTest#defaultGetObservedTimestampEpochNanos_returnsObservedTimestamp, which exercises the interface defaults via a customReadWriteLogRecordwhoseLogRecordDatahas distinct timestamp (100) and observed timestamp (200). Fails before the fix (was 100), passes after../gradlew :sdk:logs:checkpassed.## Unreleasedentry inCHANGELOG.md(replace#XXXXwith the PR number).