Preserve OpenCensus status description when converting to OpenTelemetry#8511
Draft
thswlsqls wants to merge 1 commit into
Draft
Preserve OpenCensus status description when converting to OpenTelemetry#8511thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8511 +/- ##
=========================================
Coverage 78.77% 78.77%
- Complexity 8579 8580 +1
=========================================
Files 1009 1009
Lines 28993 28997 +4
Branches 3599 3600 +1
=========================================
+ Hits 22839 22843 +4
Misses 5311 5311
Partials 843 843 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8508
Description
OpenTelemetrySpanImpl.setStatus(io.opencensus.trace.Status)mapped only the status code (OK/ERROR) and dropped the OpenCensus status description, soStatus.UNKNOWN.withDescription("connection refused")reached exporters as anERRORwith no description.status.getDescription()and forward it through the existingsetStatus(StatusCode, String)delegation — the sibling overload that already carries a description to the OpenTelemetry span — falling back to the code-only overload when the description is null.OK:SdkSpan.setStatusignores a description when the status is notERROR.Testing done
OpenTelemetrySpanImplTest#setStatus_preservesDescription(description forwarded assetStatus(ERROR, "...")) and#setStatus_withoutDescription_setsCodeOnly(no description delegates the code-only overload)../gradlew :opencensus-shim:check— passed (new test class: 2 tests).## Unreleasedentry inCHANGELOG.md(status description is now visible in exported span status).