Skip to content

Fix LongExemplarAssert hasFilteredAttributesSatisfyingExactly to enforce exact attribute matching #8518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thswlsqls wants to merge 1 commit into
base: main
Choose a base branch
from
+29 −1
Draft

Fix LongExemplarAssert hasFilteredAttributesSatisfyingExactly to enforce exact attribute matching #8518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

## Unreleased

### SDK

#### Testing

* Fix `LongExemplarAssert.hasFilteredAttributesSatisfyingExactly` to reject extra filtered
attributes, matching `DoubleExemplarAssert`
([#8518](https://github.com/open-telemetry/opentelemetry-java/pull/8518))

## Version 1.63.0 (2026-06-05)

### API
Expand Down
2 changes: 1 addition & 1 deletion sdk/testing/src/main/java/io/opentelemetry/sdk/testing/assertj/LongExemplarAssert.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ public LongExemplarAssert hasFilteredAttributesSatisfying(
*/
public LongExemplarAssert hasFilteredAttributesSatisfyingExactly(
AttributeAssertion... assertions) {
return hasFilteredAttributesSatisfying(Arrays.asList(assertions));
return hasFilteredAttributesSatisfyingExactly(Arrays.asList(assertions));
}

/**
Expand Down
20 changes: 20 additions & 0 deletions sdk/testing/src/test/java/io/opentelemetry/sdk/testing/assertj/MetricAssertionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,6 +962,26 @@ void longGaugeFailure() {
LENGTH,
val -> val.isCloseTo(1, offset(0.3))))))))
.isInstanceOf(AssertionError.class);
// hasFilteredAttributesSatisfyingExactly must reject extra filtered attributes. The exemplar
// has nine filtered attributes but only one is asserted, so the exact assertion must fail.
assertThatThrownBy(
() ->
assertThat(LONG_GAUGE_METRIC)
.hasLongGaugeSatisfying(
gauge ->
gauge.hasPointsSatisfying(
point ->
point
.hasValue(Long.MAX_VALUE)
.hasExemplarsSatisfying(
exemplar -> exemplar.hasValue(2),
exemplar ->
exemplar
.hasValue(1)
.hasFilteredAttributesSatisfyingExactly(
equalTo(BEAR, "mya"))),
point -> point.hasValue(1))))
.isInstanceOf(AssertionError.class);
}

@Test
Expand Down
Loading