opentelemetry-instrumentation-logging: add ability to configure scope attributes for LoggingHandler#4688
Open
herin049 wants to merge 2 commits into
Open
Conversation
… attributes for LoggingHandler
| record.name, logger_provider=self._logger_provider | ||
| record.name, | ||
| logger_provider=self._logger_provider, | ||
| attributes=self._scope_attributes, |
Contributor
There was a problem hiding this comment.
Looks like a possible perfromance regression here. Passing attributes to get_logger bypasses the _get_logger_cached path every time. So emit() will always allocate a brand new Logger + InstrumentationScope. Possibly update the caching logic.
Contributor
Author
There was a problem hiding this comment.
Thanks, we might just want to add an internal cache inside of the LoggingHandler itself.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds ability to configure scope attributes for the internal SDK logger used by the
LoggingHandlerinopentelemetry-instrumentation-logging.Fixes opentelemetry-python#4060
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.