opentelemetry-instrumentation-requests: remove multiple calls to sanitize_method#4719
Open
codeboten wants to merge 3 commits into
Open
opentelemetry-instrumentation-requests: remove multiple calls to sanitize_method#4719codeboten wants to merge 3 commits into
codeboten wants to merge 3 commits into
Conversation
…tize_method Instead call the method once and pass the results in where needed Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
emdneto
approved these changes
Jun 22, 2026
emdneto
left a comment
emdneto
left a comment
Member
There was a problem hiding this comment.
Thanks for the benchmark. Tested it and it's working fine, but I don't think the results are being published/tracked anywhere. I'll open an issue for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead call the method once and pass the results in where needed
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Benchmarks with similar results to #4718
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.