fix(fastapi): handle _IncludedRouter in FastAPI v0.137.0+#4722
Open
muhamedfazalps wants to merge 1 commit into
Open
fix(fastapi): handle _IncludedRouter in FastAPI v0.137.0+#4722muhamedfazalps wants to merge 1 commit into
muhamedfazalps wants to merge 1 commit into
Conversation
FastAPI v0.137.0 changed router.routes from a flat list to a tree structure. Included routers are now wrapped in _IncludedRouter objects that lack a path attribute, causing AttributeError in _get_route_details(). This fix recurses into the sub-routes of _IncludedRouter (via original_router.routes) to find the actual matching route and its path. Also adds try/except for the PARTIAL match path which had the same latent bug. Fixes open-telemetry#4699 Assisted-by: Claude Opus 4.6
|
|
Can this be merged please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FastAPI v0.137.0 changed
router.routesfrom a flat list to a tree structure. Included routers are now wrapped in_IncludedRouterobjects that lack apathattribute, causingAttributeErrorin_get_route_details().This fix recurses into the sub-routes of
_IncludedRouter(viaoriginal_router.routes) to find the actual matching route and its path. Also addstry/exceptfor thePARTIALmatch path which had the same latent bug.Fix
_get_route_details()encounters a route without apathattribute (like_IncludedRouter), it now checks forroutesororiginal_router.routesand iterates through sub-routes to find the matching onetry/exceptaround thePARTIALmatch path access (line 495) which previously had no error handling_IncludedRouterTesting
Verified with:
app.include_router()) - now resolves correctlyFixes #4699
If you find this helpful, consider buying me a coffee