Feature/kafka cluster#4727
Open
shashank-reddy-nr wants to merge 1 commit into
Open
Conversation
|
|
When a service connects to multiple Kafka clusters, or when the same topic name exists across environments, Kafka spans carry no information about which cluster a message came from. messaging.cluster.id is defined in the OTel messaging semantic conventions for Kafka but was not previously set by this instrumentation. Adds messaging.cluster.id as a span attribute on producer and consumer spans for Confluent.Kafka (≥2.0.0). A one-time background AdminClient.DescribeClusterAsync() call is made per unique bootstrap-servers string; security config (SASL/SSL) is forwarded so authenticated clusters are supported. The attribute is omitted on older library versions or if resolution has not yet completed — no overhead on the hot path. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
shashank-reddy-nr
force-pushed
the
feature/kafka-cluster-id
branch
from
937e539 to
3760932
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.