Skip to content

fix(openai-agents): use SpanKind.INTERNAL for invoke_agent root span #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bhumikadangayach wants to merge 2 commits into from
+17 −1
Closed

fix(openai-agents): use SpanKind.INTERNAL for invoke_agent root span #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e64bfcf
fix(openai-agents): use SpanKind.INTERNAL for invoke_agent root span
bhumikadangayach Jun 20, 2026
911a0d8
fix: update misleading comment on root span kind per Copilot review
bhumikadangayach Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...nai-openai-agents/src/opentelemetry/instrumentation/genai/openai_agents/span_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1312,7 +1312,7 @@ def on_trace_start(self, trace: Trace) -> None:
otel_span = self._tracer.start_span(
name=trace.name,
attributes=attributes,
kind=SpanKind.SERVER, # Root span is typically server
kind=SpanKind.INTERNAL, # Root span represents local workflow; not a remote server span
)
self._root_spans[trace.trace_id] = otel_span

Expand Down
16 changes: 16 additions & 0 deletions ...ion/opentelemetry-instrumentation-genai-openai-agents/tests/test_z_span_processor_unit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,6 +503,22 @@ def test_span_lifecycle_and_shutdown(processor_setup):
== sp.GenAIOperationName.INVOKE_AGENT
)

def test_root_span_kind_is_internal(processor_setup):
"""Regression test for #154: root span must be INTERNAL, not SERVER.

invoke_agent root spans don't represent the server side of a
synchronous remote call, so SpanKind.SERVER is incorrect per the
OTel semantic conventions for span kinds.
"""
processor, exporter = processor_setup

trace = FakeTrace(name="workflow", trace_id="trace-root-kind")
processor.on_trace_start(trace)
processor.on_trace_end(trace)

finished = exporter.get_finished_spans()
assert len(finished) == 1
assert finished[0].kind is SpanKind.INTERNAL

def test_chat_span_renamed_with_model(processor_setup):
processor, exporter = processor_setup
Expand Down
Loading