feat(lambda): read cloud.account.id from symlink in Lambda detector#1995
Open
RaphaelManke wants to merge 5 commits intoopen-telemetry:mainfrom
Open
feat(lambda): read cloud.account.id from symlink in Lambda detector#1995RaphaelManke wants to merge 5 commits intoopen-telemetry:mainfrom
RaphaelManke wants to merge 5 commits intoopen-telemetry:mainfrom
Conversation
Read /tmp/.otel-account-id symlink (created by the OTel Lambda extension) using File.readlink to populate the cloud.account.id resource attribute. Silently skips if the symlink does not exist (ENOENT) or is not a symlink (EINVAL). Account ID is treated as a string to preserve leading zeros.
RaphaelManke
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
Contributor
|
@jterapin @alextwoods @NathanielRN May I ask for a review from AWS Ruby SDK team? |
Contributor
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloud.account.idfrom the symlink at/tmp/.otel-aws-account-idcreated by the OTel Lambda ExtensionFile.readlink()to read the symlink targetrescue Errno::ENOENT, Errno::EINVAL)Depends on
Changes
lambda.rb— Added readlink logic withACCOUNT_ID_SYMLINK_PATHconstantTest plan
cloud.account.idset correctly